[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH v3 07/28] target/arm: Assert no manual change to CACHE
From: |
Richard Henderson |
Subject: |
[Qemu-arm] [PATCH v3 07/28] target/arm: Assert no manual change to CACHED_PSTATE_BITS |
Date: |
Mon, 11 Feb 2019 15:52:37 -0800 |
These bits are stored elsewhere; changing env->pstate has no effect.
Suggested-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target/arm/translate.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target/arm/translate.h b/target/arm/translate.h
index a24757d3d7..296d1ac72c 100644
--- a/target/arm/translate.h
+++ b/target/arm/translate.h
@@ -209,6 +209,8 @@ static inline void set_pstate_bits(uint32_t bits)
{
TCGv_i32 p = tcg_temp_new_i32();
+ tcg_debug_assert(!(bits & CACHED_PSTATE_BITS));
+
tcg_gen_ld_i32(p, cpu_env, offsetof(CPUARMState, pstate));
tcg_gen_ori_i32(p, p, bits);
tcg_gen_st_i32(p, cpu_env, offsetof(CPUARMState, pstate));
@@ -220,6 +222,8 @@ static inline void clear_pstate_bits(uint32_t bits)
{
TCGv_i32 p = tcg_temp_new_i32();
+ tcg_debug_assert(!(bits & CACHED_PSTATE_BITS));
+
tcg_gen_ld_i32(p, cpu_env, offsetof(CPUARMState, pstate));
tcg_gen_andi_i32(p, p, ~bits);
tcg_gen_st_i32(p, cpu_env, offsetof(CPUARMState, pstate));
--
2.17.2
- [Qemu-arm] [PATCH v3 03/28] target/arm: Add clear_pstate_bits, share gen_ss_advance, (continued)
- [Qemu-arm] [PATCH v3 03/28] target/arm: Add clear_pstate_bits, share gen_ss_advance, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 04/28] target/arm: Add MTE_ACTIVE to tb_flags, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 05/28] target/arm: Extract TCMA with ARMVAParameters, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 10/28] target/arm: Implement the IRG instruction, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 18/28] target/arm: Implement the access tag cache flushes, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 14/28] target/arm: Define arm_cpu_do_unaligned_access for CONFIG_USER_ONLY, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 06/28] target/arm: Add MTE system registers, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 20/28] target/arm: Implement data cache set allocation tags, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 12/28] target/arm: Implement the GMI instruction, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 13/28] target/arm: Implement the SUBP instruction, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 07/28] target/arm: Assert no manual change to CACHED_PSTATE_BITS,
Richard Henderson <=
- [Qemu-arm] [PATCH v3 21/28] target/arm: Set PSTATE.TCO on exception entry, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 16/28] target/arm: Implement the STGP instruction, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 08/28] target/arm: Add helper_mte_check{1,2}, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 19/28] target/arm: Clean address for DC ZVA, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 15/28] target/arm: Implement LDG, STG, ST2G instructions, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 11/28] target/arm: Implement ADDG, SUBG instructions, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 23/28] target/arm: Cache the Tagged bit for a page in MemTxAttrs, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 27/28] target/arm: Enable MTE, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 09/28] target/arm: Suppress tag check for sp+offset, Richard Henderson, 2019/02/11
- [Qemu-arm] [PATCH v3 28/28] tests/tcg/aarch64: Add mte smoke tests, Richard Henderson, 2019/02/11