[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 01/14] hw/arm/armsse: Fix miswiring o
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 01/14] hw/arm/armsse: Fix miswiring of expansion IRQs |
Date: |
Sun, 17 Feb 2019 09:49:18 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/14/19 4:50 AM, Peter Maydell wrote:
> In commit 91c1e9fcbd7548db368 where we added dual-CPU support to
> the ARMSSE, we set up the wiring of the expansion IRQs via nested
> loops: the outer loop on 'i' loops for each CPU, and the inner loop
> on 'j' loops for each interrupt. Fix a typo which meant we were
> wiring every expansion IRQ line to external IRQ 0 on CPU 0 and
> to external IRQ 1 on CPU 1.
>
> Fixes: 91c1e9fcbd7548db368 ("hw/arm/armsse: Support dual-CPU configuration")
> Signed-off-by: Peter Maydell <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/arm/armsse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [Qemu-arm] [Qemu-devel] [PATCH 04/14] hw/timer/pl031: Convert to using trace events, (continued)
- [Qemu-arm] [PATCH 14/14] hw/arm/musca: Wire up PL011 UARTs, Peter Maydell, 2019/02/14
- [Qemu-arm] [PATCH 11/14] hw/arm/musca: Add PPCs, Peter Maydell, 2019/02/14
- [Qemu-arm] [PATCH 07/14] hw/char/pl011: Use '0x' prefix when logging hex numbers, Peter Maydell, 2019/02/14
- [Qemu-arm] [PATCH 01/14] hw/arm/armsse: Fix miswiring of expansion IRQs, Peter Maydell, 2019/02/14
- Re: [Qemu-arm] [Qemu-devel] [PATCH 01/14] hw/arm/armsse: Fix miswiring of expansion IRQs,
Richard Henderson <=
- [Qemu-arm] [PATCH 06/14] hw/char/pl011: Support all interrupt lines, Peter Maydell, 2019/02/14
- [Qemu-arm] [PATCH 05/14] hw/char/pl011: Allow use as an embedded-struct device, Peter Maydell, 2019/02/14
- [Qemu-arm] [PATCH 03/14] hw/timer/pl031: Allow use as an embedded-struct device, Peter Maydell, 2019/02/14
- [Qemu-arm] [PATCH 08/14] hw/arm/armsse: Document SRAM_ADDR_WIDTH property in header comment, Peter Maydell, 2019/02/14