[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 13/18] hw/nvram/fw_cfg: Add QMP 'i
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 13/18] hw/nvram/fw_cfg: Add QMP 'info fw_cfg' command |
Date: |
Tue, 12 Mar 2019 15:17:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
Hi Markus,
On 03/09/19 16:04, Markus Armbruster wrote:
> The subject "Add QMP 'info fw_cfg' command" misspells query-fw_cfg-items
> :)
>
> Eric Blake <address@hidden> writes:
>
>> On 3/7/19 7:32 PM, Philippe Mathieu-Daudé wrote:
>>> +##
>>> +# @FirmwareConfigurationItem:
>>> +#
>>> +# Firmware Configuration (fw_cfg) item.
>>> +#
>>> +# @key: The uint16 selector key.
>>> +# @keyname: The stringified name if the selector refers to a well-known
>>> +# numerically defined item.
>
> Ignorant questions, I'm afraid...
>
> What determines the possible values of @key?
the text file "docs/specs/fw_cfg.txt" explains this somewhat.
- In section "Selector (Control) Register", it lays out the structure of
the key space.
> What's the difference between a "well-known" and a "not well-known"
> value? Examples?
- In section "Firmware Configuration Items", it explains the selectors
FW_CFG_SIGNATURE, FW_CFG_ID, FW_CFG_FILE_DIR.
- Then it "implies" readers should consult
"include/standard-headers/linux/qemu_fw_cfg.h". :)
All in all, a selector is "well known" if the QEMU source code defines
-- perhaps through incorporating a kernel include file -- a macro
directly for the numeric value of the selector key. Such a selector is
"well known" because guest firmware is allowed / required to refer
directly to the numeric value, rather than to look it up in the fw_cfg
file directory, by name (such as "etc/table-loader", "bootorder", ...).
Thanks!
Laszlo
- Re: [Qemu-arm] [PATCH v2 12/18] hw/nvram/fw_cfg: Keep reference of file_data in FWCfgState, (continued)
- [Qemu-arm] [PATCH v2 13/18] hw/nvram/fw_cfg: Add QMP 'info fw_cfg' command, Philippe Mathieu-Daudé, 2019/03/07
- Re: [Qemu-arm] [PATCH v2 13/18] hw/nvram/fw_cfg: Add QMP 'info fw_cfg' command, Eric Blake, 2019/03/07
- Re: [Qemu-arm] [PATCH v2 13/18] hw/nvram/fw_cfg: Add QMP 'info fw_cfg' command, Philippe Mathieu-Daudé, 2019/03/08
- Re: [Qemu-arm] [PATCH v2 13/18] hw/nvram/fw_cfg: Add QMP 'info fw_cfg' command, Eric Blake, 2019/03/08
- Re: [Qemu-arm] [PATCH v2 13/18] hw/nvram/fw_cfg: Add QMP 'info fw_cfg' command, Philippe Mathieu-Daudé, 2019/03/08
- Re: [Qemu-arm] [PATCH v2 13/18] hw/nvram/fw_cfg: Add QMP 'info fw_cfg' command, Laszlo Ersek, 2019/03/08
- Re: [Qemu-arm] [PATCH v2 13/18] hw/nvram/fw_cfg: Add QMP 'info fw_cfg' command, Philippe Mathieu-Daudé, 2019/03/08
- Re: [Qemu-arm] [Qemu-devel] [PATCH v2 13/18] hw/nvram/fw_cfg: Add QMP 'info fw_cfg' command, Markus Armbruster, 2019/03/09
- Re: [Qemu-arm] [Qemu-devel] [PATCH v2 13/18] hw/nvram/fw_cfg: Add QMP 'info fw_cfg' command,
Laszlo Ersek <=
[Qemu-arm] [PATCH v2 14/18] hw/nvram/fw_cfg: Add HMP 'info fw_cfg' command, Philippe Mathieu-Daudé, 2019/03/07
[Qemu-arm] [PATCH v2 15/18] hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host(), Philippe Mathieu-Daudé, 2019/03/07
[Qemu-arm] [PATCH v2 16/18] hw/firmware: Add Edk2Crypto and edk2_add_host_crypto_policy(), Philippe Mathieu-Daudé, 2019/03/07
[Qemu-arm] [PATCH v2 17/18] hw/i386: Use edk2_add_host_crypto_policy(), Philippe Mathieu-Daudé, 2019/03/07
[Qemu-arm] [PATCH v2 18/18] hw/arm/virt: Use edk2_add_host_crypto_policy(), Philippe Mathieu-Daudé, 2019/03/07
Re: [Qemu-arm] [PATCH v2 00/18] fw_cfg: reduce memleaks, add QMP/HMP info + edk2_add_host_crypto_policy, Laszlo Ersek, 2019/03/08