[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [RFC PATCH] cputlb: use uint64_t for interim values for unali
From: |
Alex Bennée |
Subject: |
[Qemu-arm] [RFC PATCH] cputlb: use uint64_t for interim values for unaligned load |
Date: |
Mon, 3 Jun 2019 16:01:20 +0100 |
When running on 32 bit TCG backends a wide unaligned load ends up
truncating data before returning to the guest. We specifically have
the return type as uint64_t to avoid any premature truncation so we
should use the same for the interim types.
Hopefully fixes #1830872
Signed-off-by: Alex Bennée <address@hidden>
---
accel/tcg/cputlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index cdcc3771020..b796ab1cbea 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -1303,7 +1303,7 @@ load_helper(CPUArchState *env, target_ulong addr,
TCGMemOpIdx oi,
&& unlikely((addr & ~TARGET_PAGE_MASK) + size - 1
>= TARGET_PAGE_SIZE)) {
target_ulong addr1, addr2;
- tcg_target_ulong r1, r2;
+ uint64_t r1, r2;
unsigned shift;
do_unaligned_access:
addr1 = addr & ~(size - 1);
--
2.20.1
- [Qemu-arm] [RFC PATCH] cputlb: use uint64_t for interim values for unaligned load,
Alex Bennée <=
- Re: [Qemu-arm] [RFC PATCH] cputlb: use uint64_t for interim values for unaligned load, Andrew Randrianasulu, 2019/06/03
- Re: [Qemu-arm] [Qemu-devel] [RFC PATCH] cputlb: use uint64_t for interim values for unaligned load, Laszlo Ersek, 2019/06/03
- Re: [Qemu-arm] [Qemu-devel] [RFC PATCH] cputlb: use uint64_t for interim values for unaligned load, Richard Henderson, 2019/06/03
- Re: [Qemu-arm] [Qemu-devel] [RFC PATCH] cputlb: use uint64_t for interim values for unaligned load, Philippe Mathieu-Daudé, 2019/06/04
- Re: [Qemu-arm] [Qemu-devel] [RFC PATCH] cputlb: use uint64_t for interim values for unaligned load, Igor Mammedov, 2019/06/04