Re: [Qemu-arm] [Qemu-devel] [PATCH v2 7/8] hw/misc: Add a config switch for the "unimplemented" device

[Thomas Huth]

On 31/07/2019 17.59, Philippe Mathieu-Daudé wrote:
> On Wed, Jul 31, 2019 at 5:55 PM Philippe Mathieu-Daudé
> <address@hidden> wrote:
>> On 7/31/19 1:50 PM, Thomas Huth wrote:
>>> On 31/07/2019 13.47, Philippe Mathieu-Daudé wrote:
>>>> On 7/31/19 9:56 AM, Thomas Huth wrote:
>>>>> The device is only used by some few boards. Let's use a proper Kconfig
>>>>> switch so that we only compile this code if we really need it.
>>>>
>>>> I'd prefer having the UnimpDevice user-creatable and always present as a
>>>> core device...
>>>
>>> Why? This is a sysbus device that needs to be wired up in code, so I
>>> don't see a reason for making this user-creatable right now.
>>
>> Right now no.
>>
>>> Anyway, that's a different subject, so this should not be part of this
>>> patch.
>>
>> Fair enough.
>>
>> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> 
> Err, you missed MUSCA and MPS2.

Ah, well, that's another one of those indirections that we discussed in
v1 and which I apparently forgot to add now in v2 ... both select ARMSSE
which in turn select UNIMP, so it's not completely missing. I'll send a
v3 with a fix.

Thanks for noticing!

 Thomas