[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 7/7] target/arm: Use tcg_gen_extrh_i64_i32 to extr
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-arm] [PATCH 7/7] target/arm: Use tcg_gen_extrh_i64_i32 to extract the high word |
|
Date: |
Thu, 15 Aug 2019 12:56:45 +0100 |
|
User-agent: |
K-9 Mail for Android |
>
>This patch is fine, but I noticed while reviewing it that tcg/README
>labels both the extrl_i64_i32 and extrh_i64_i32 operations as
>"for 64-bit hosts only". Presumably that's a documentation error,
>since we're not guarding the existing uses of the extrl_i64_i32
>here with any kind of ifdeffery to restrict them to 64-bit hosts ?
>
A documentation unclarity in that the opcodes are for 64-bit hosts. The
tcg_gen_* functions are always available, and expand to INDEX_op_mov_i32 on
32-bit hosts.
r~
- [Qemu-arm] [PATCH 0/7] target/arm: Misc cleanups, Richard Henderson, 2019/08/08
- [Qemu-arm] [PATCH 1/7] target/arm: Use tcg_gen_extract_i32 for shifter_out_im, Richard Henderson, 2019/08/08
- [Qemu-arm] [PATCH 2/7] target/arm: Use tcg_gen_deposit_i32 for PKHBT, PKHTB, Richard Henderson, 2019/08/08
- [Qemu-arm] [PATCH 3/7] target/arm: Remove redundant shift tests, Richard Henderson, 2019/08/08
- [Qemu-arm] [PATCH 4/7] target/arm: Use ror32 instead of open-coding the operation, Richard Henderson, 2019/08/08
- [Qemu-arm] [PATCH 5/7] target/arm: Use tcg_gen_rotri_i32 for gen_swap_half, Richard Henderson, 2019/08/08
- [Qemu-arm] [PATCH 6/7] target/arm: Simplify SMMLA, SMMLAR, SMMLS, SMMLSR, Richard Henderson, 2019/08/08
- [Qemu-arm] [PATCH 7/7] target/arm: Use tcg_gen_extrh_i64_i32 to extract the high word, Richard Henderson, 2019/08/08
- Re: [Qemu-arm] [PATCH 0/7] target/arm: Misc cleanups, Peter Maydell, 2019/08/15