[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [qemu-s390x] [Qemu-devel] [PATCH v7 33/42] exec: Replace
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-arm] [qemu-s390x] [Qemu-devel] [PATCH v7 33/42] exec: Replace device_endian with MemOp |
Date: |
Mon, 19 Aug 2019 20:28:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 16/08/19 12:12, Thomas Huth wrote:
> This patch is *huge*, more than 800kB. It keeps being stuck in the the
> filter of the qemu-s390x list each time you send it. Please:
>
> 1) Try to break it up in more digestible pieces, e.g. change only one
> subsystem at a time (this is also better reviewable by people who are
> interested in one area)
This is not really possible, since the patch is basically a
search-and-replace. You could perhaps use some magic
("DEVICE_MEMOP_ENDIAN" or something like that) to allow a split, but it
would introduce more complication than anything else.
Agreed on the HTML though. :)
Paolo
- [Qemu-arm] [Qemu-devel] [PATCH v7 29/42] hw/ssi: Declare device little or big endian, (continued)
- [Qemu-arm] [Qemu-devel] [PATCH v7 29/42] hw/ssi: Declare device little or big endian, tony.nguyen, 2019/08/16
- [Qemu-arm] [Qemu-devel] [PATCH v7 31/42] build: Correct non-common common-obj-* to obj-*, tony.nguyen, 2019/08/16
- [Qemu-arm] [Qemu-devel] [PATCH v7 32/42] exec: Map device_endian onto MemOp, tony.nguyen, 2019/08/16
- [Qemu-arm] [Qemu-devel] [PATCH v7 30/42] hw/timer: Declare device little or big endian, tony.nguyen, 2019/08/16
- [Qemu-arm] [Qemu-devel] [PATCH v7 34/42] exec: Delete device_endian, tony.nguyen, 2019/08/16
- [Qemu-arm] [Qemu-devel] [PATCH v7 35/42] exec: Delete DEVICE_HOST_ENDIAN, tony.nguyen, 2019/08/16
- [Qemu-arm] [Qemu-devel] [PATCH v7 36/42] memory: Access MemoryRegion with endianness, tony.nguyen, 2019/08/16
- [Qemu-arm] [Qemu-devel] [PATCH v7 33/42] exec: Replace device_endian with MemOp, tony.nguyen, 2019/08/16
[Qemu-arm] [Qemu-devel] [PATCH v7 38/42] memory: Single byte swap along the I/O path, tony.nguyen, 2019/08/16
[Qemu-arm] [Qemu-devel] [PATCH v7 39/42] cpu: TLB_FLAGS_MASK bit to force memory slow path, tony.nguyen, 2019/08/16
[Qemu-arm] [Qemu-devel] [PATCH v7 40/42] cputlb: Byte swap memory transaction attribute, tony.nguyen, 2019/08/16
[Qemu-arm] [Qemu-devel] [PATCH v7 37/42] cputlb: Replace size and endian operands for MemOp, tony.nguyen, 2019/08/16
[Qemu-arm] [Qemu-devel] [PATCH v7 41/42] target/sparc: Add TLB entry with attributes, tony.nguyen, 2019/08/16