Re: [Qemu-arm] [PATCH v2 3/6] hw/arm: Use sysbus_init_child_obj for correct reference counting

[Thomas Huth]

On 8/23/19 4:32 PM, Philippe Mathieu-Daudé wrote:
> As explained in commit aff39be0ed97:
> 
>   Both functions, object_initialize() and qdev_set_parent_bus()

Commit aff39be0ed97 was not about qdev_set_parent_bus(), so the first
sentence sounds somewhat misleading here. Maybe rephrase the commit
message without that reference to aff39be0ed97 ?

>   increase the reference counter of the new object, so one of the
>   references has to be dropped afterwards to get the reference
>   counting right. Otherwise the child object will not be properly
>   cleaned up when the parent gets destroyed.

Well, the parent here (the machine) currently never gets destroyed ...
so unless you've got a patch in your pipe to fix that, too, you should
maybe also rephrase this part of the commit message.

 Thomas