Re: [Qemu-arm] [Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

[Richard Henderson]

On 8/25/19 6:10 PM, Richard Henderson wrote:
> On 8/25/19 1:43 PM, Peter Maydell wrote:
>> I'm still confused, I think. The hint space is
>> +  NOP            1111 0011 1010 1111 1000 0000 ---- ----
>> (plus the more specific hint insns before that pattern with
>> fixed values in the [7:0] bits).
>> CPS falls into that space; but you've placed it with
>> SMC and HVC which don't fall into the hint space, because
>> they have 0111 in bits [27:24], not 0011.
> 
> Oops.  I see what you mean.

So, I've moved the line up immediately following the hint space, and added a
comment:

+    # If imod == '00' && M == '0' then SEE "Hint instructions", above.
+    CPS          1111 0011 1010 1111 1000 0 imod:2 M:1 A:1 I:1 F:1 mode:5 \
+                 &cps

The line *was* still within the same group (which is large), so it doesn't
actually make a difference to the decode, but I do agree it makes more sense in
the new position.


r~