Re: [PATCH 10/16] target/arm: Use SVEContLdSt for multi-register contiguous loads

[Peter Maydell]

On Wed, 11 Mar 2020 at 06:44, Richard Henderson
<address@hidden> wrote:
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/arm/sve_helper.c | 223 ++++++++++++++--------------------------
>  1 file changed, 79 insertions(+), 144 deletions(-)


>  #define DO_LDN_1(N) \
> -void QEMU_FLATTEN HELPER(sve_ld##N##bb_r) \
> -    (CPUARMState *env, void *vg, target_ulong addr, uint32_t desc)  \
> -{                                                                   \
> -    sve_ld##N##_r(env, vg, addr, desc, 1, GETPC(), sve_ld1bb_tlb);  \
> +void HELPER(sve_ld##N##bb_r)(CPUARMState *env, void *vg,        \
> +                             target_ulong addr, uint32_t desc)  \
> +{                                                               \
> +    sve_ldN_r(env, vg, addr, desc, GETPC(), MO_8, MO_8, N,      \
> +              sve_ld1bb_host, sve_ld1bb_tlb);                   \
>  }

Deliberately losing the QEMU_FLATTEN here?

Otherwise

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM