Re: [PATCH v2 8/8] hw/arm/fsl-imx7: Connect watchdog interrupts

[Peter Maydell]

On Sun, 22 Mar 2020 at 21:19, Guenter Roeck <address@hidden> wrote:
>
> i.MX7 supports watchdog pretimeout interupts. With this commit,
> the watchdog in mcimx7d-sabre is fully operational, including
> pretimeout support.
>
> Signed-off-by: Guenter Roeck <address@hidden>

> diff --git a/include/hw/arm/fsl-imx7.h b/include/hw/arm/fsl-imx7.h
> index 47826da2b7..da977f9ffb 100644
> --- a/include/hw/arm/fsl-imx7.h
> +++ b/include/hw/arm/fsl-imx7.h
> @@ -228,6 +228,11 @@ enum FslIMX7IRQs {
>      FSL_IMX7_USB2_IRQ     = 42,
>      FSL_IMX7_USB3_IRQ     = 40,
>
> +    FSL_IMX7_WDOG1_IRQ    = 78,
> +    FSL_IMX7_WDOG2_IRQ    = 79,
> +    FSL_IMX7_WDOG3_IRQ    = 10,
> +    FSL_IMX7_WDOG4_IRQ    = 109,

irq 10 for wdog3 seems to match the kernel's dts, but it's
a bit weird that it's way out of the range of the others.
Did you sanity check it against the imx7 data sheet and/or
real h/w behaviour that it's not a typo for
one-hundred-and-something? (108 would be the obvious guess...)

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM