[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 02/11] hw/arm: versal: Move misplaced comment
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v1 02/11] hw/arm: versal: Move misplaced comment |
Date: |
Tue, 28 Apr 2020 09:46:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 4/27/20 8:16 PM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <address@hidden>
>
> Move misplaced comment.
>
> Signed-off-by: Edgar E. Iglesias <address@hidden>
> ---
> hw/arm/xlnx-versal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c
> index c73b2fe755..cc696e44c0 100644
> --- a/hw/arm/xlnx-versal.c
> +++ b/hw/arm/xlnx-versal.c
> @@ -36,7 +36,6 @@ static void versal_create_apu_cpus(Versal *s)
>
> obj = object_new(XLNX_VERSAL_ACPU_TYPE);
> if (!obj) {
> - /* Secondary CPUs start in PSCI powered-down state */
> error_report("Unable to create apu.cpu[%d] of type %s",
> i, XLNX_VERSAL_ACPU_TYPE);
> exit(EXIT_FAILURE);
> @@ -49,6 +48,7 @@ static void versal_create_apu_cpus(Versal *s)
> object_property_set_int(obj, s->cfg.psci_conduit,
> "psci-conduit", &error_abort);
> if (i) {
> + /* Secondary CPUs start in PSCI powered-down state */
> object_property_set_bool(obj, true,
> "start-powered-off", &error_abort);
> }
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
- [PATCH v1 08/11] hw/arm: versal: Add support for SD, (continued)
- [PATCH v1 08/11] hw/arm: versal: Add support for SD, Edgar E. Iglesias, 2020/04/27
- [PATCH v1 04/11] hw/arm: versal: Embedd the UARTs into the SoC type, Edgar E. Iglesias, 2020/04/27
- [PATCH v1 02/11] hw/arm: versal: Move misplaced comment, Edgar E. Iglesias, 2020/04/27
- [PATCH v1 09/11] hw/arm: versal: Add support for the RTC, Edgar E. Iglesias, 2020/04/27
- [PATCH v1 10/11] hw/arm: versal-virt: Add support for SD, Edgar E. Iglesias, 2020/04/27
- [PATCH v1 07/11] hw/arm: versal: Embedd the APUs into the SoC type, Edgar E. Iglesias, 2020/04/27