[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/36] target/arm: Convert VFM[AS]L (vector) to decodetree
From: |
Richard Henderson |
Subject: |
Re: [PATCH 07/36] target/arm: Convert VFM[AS]L (vector) to decodetree |
Date: |
Thu, 30 Apr 2020 11:43:56 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 4/30/20 11:09 AM, Peter Maydell wrote:
> Convert the VFM[AS]L (vector) insns to decodetree. This is the last
> insn in the legacy decoder for the 3same_ext group, so we can
> delete the legacy decoder function for the group entirely.
>
> Note that in disas_thumb2_insn() the parts of this encoding space
> where the decodetree decoder returns false will correctly be directed
> to illegal_op by the "(insn & (1 << 28))" check so they won't fall
> into disas_coproc_insn() by mistake.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> target/arm/translate-neon.inc.c | 31 +++++++++++
> target/arm/translate.c | 92 +--------------------------------
> target/arm/neon-shared.decode | 6 +++
> 3 files changed, 38 insertions(+), 91 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [PATCH 01/36] target/arm/translate-vfp.inc.c: Remove duplicate simd_r32 check, (continued)
- [PATCH 04/36] target/arm: Convert VCMLA (vector) to decodetree, Peter Maydell, 2020/04/30
- [PATCH 06/36] target/arm: Convert V[US]DOT (vector) to decodetree, Peter Maydell, 2020/04/30
- [PATCH 08/36] target/arm: Convert VCMLA (scalar) to decodetree, Peter Maydell, 2020/04/30
- [PATCH 05/36] target/arm: Convert VCADD (vector) to decodetree, Peter Maydell, 2020/04/30
- [PATCH 07/36] target/arm: Convert VFM[AS]L (vector) to decodetree, Peter Maydell, 2020/04/30
- Re: [PATCH 07/36] target/arm: Convert VFM[AS]L (vector) to decodetree,
Richard Henderson <=
- [PATCH 09/36] target/arm: Convert V[US]DOT (scalar) to decodetree, Peter Maydell, 2020/04/30
- [PATCH 10/36] target/arm: Convert VFM[AS]L (scalar) to decodetree, Peter Maydell, 2020/04/30
- [PATCH 11/36] target/arm: Convert Neon load/store multiple structures to decodetree, Peter Maydell, 2020/04/30
- [PATCH 12/36] target/arm: Convert Neon 'load single structure to all lanes' to decodetree, Peter Maydell, 2020/04/30
- [PATCH 13/36] target/arm: Convert Neon 'load/store single structure' to decodetree, Peter Maydell, 2020/04/30