Re: [PATCH] hw/usb: Make "hcd-ehci.h" header public

[Philippe Mathieu-Daudé]

On 5/4/20 10:48 AM, BALATON Zoltan wrote:
> On Mon, 4 May 2020, Philippe Mathieu-Daudé wrote:
> > As target-specific code use this header, move it to the publicly
> > accessible include/ folder.
> >
> >  $ git grep hw/usb/hcd-ehci.h
> >  hw/arm/allwinner-h3.c:31:#include "hw/usb/hcd-ehci.h"
> >  hw/arm/exynos4210.c:38:#include "hw/usb/hcd-ehci.h"
> >  hw/ppc/sam460ex.c:38:#include "hw/usb/hcd-ehci.h"
> >  include/hw/arm/allwinner-a10.h:13:#include "hw/usb/hcd-ehci.h"
> >  include/hw/arm/aspeed_soc.h:29:#include "hw/usb/hcd-ehci.h"
>
> All of these only need either the type #define or EHCISysBusState so 
> splitting only those off to a public header should be enough and better 
> than making public all of ehci's internal header.

Ah you mean forward-declare EHCISysBusState in "qemu/typedefs.h", OK.

> Regards,
> BALATON Zoltan