[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/7] hw/arm/boot: Abort if set_kernel_args() fails
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v2 5/7] hw/arm/boot: Abort if set_kernel_args() fails |
|
Date: |
Mon, 18 May 2020 17:08:22 +0100 |
On Mon, 18 May 2020 at 16:53, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> If a address_space_write() fails while calling
> set_kernel_args(), the guest kernel will boot
> using crap data. Avoid that by aborting if this
> ever occurs.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
I think it's reasonable to make these be fatal, but I think we
shouldn't just assert() but instead make set_kernel_arg()
and set_kernel_args_old() return a success/failure indication,
and report failures to the user as fatal errors.
thanks
-- PMM
- [PATCH v2 0/7] exec/memory: Enforce checking MemTxResult values, Philippe Mathieu-Daudé, 2020/05/18
- [PATCH v2 1/7] exec: Let address_space_read/write_cached() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/05/18
- [PATCH v2 2/7] exec: Propagate cpu_memory_rw_debug() error, Philippe Mathieu-Daudé, 2020/05/18
- [PATCH v2 4/7] hw/elf_ops: Do not ignore write failures when loading ELF, Philippe Mathieu-Daudé, 2020/05/18
- [PATCH v2 5/7] hw/arm/boot: Abort if set_kernel_args() fails, Philippe Mathieu-Daudé, 2020/05/18
- Re: [PATCH v2 5/7] hw/arm/boot: Abort if set_kernel_args() fails,
Peter Maydell <=
- [RFC PATCH v2 6/7] accel/kvm: Let KVM_EXIT_MMIO return error, Philippe Mathieu-Daudé, 2020/05/18
- [PATCH v2 3/7] disas: Let disas::read_memory() handler return EIO on error, Philippe Mathieu-Daudé, 2020/05/18
- [RFC PATCH v2 7/7] hw/core/loader: Assert loading ROM regions succeeds at reset, Philippe Mathieu-Daudé, 2020/05/18
- Re: [PATCH v2 0/7] exec/memory: Enforce checking MemTxResult values, Paolo Bonzini, 2020/05/21