[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 14/21] hw/display/pxa2xx_lcd: Replace printf() call by qemu_log_ma
From: |
Gerd Hoffmann |
Subject: |
[PULL 14/21] hw/display/pxa2xx_lcd: Replace printf() call by qemu_log_mask() |
Date: |
Thu, 28 May 2020 14:36:02 +0200 |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Replace printf() calls by qemu_log_mask(UNIMP), which is
disabled by default. This avoid flooding the terminal when
fuzzing the device.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200526062252.19852-15-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/pxa2xx_lcd.c | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/hw/display/pxa2xx_lcd.c b/hw/display/pxa2xx_lcd.c
index d5f2e82a4ec3..ff90104b8011 100644
--- a/hw/display/pxa2xx_lcd.c
+++ b/hw/display/pxa2xx_lcd.c
@@ -426,9 +426,10 @@ static void pxa2xx_lcdc_write(void *opaque, hwaddr offset,
if ((s->control[0] & LCCR0_ENB) && !(value & LCCR0_ENB))
s->status[0] |= LCSR0_QD;
- if (!(s->control[0] & LCCR0_LCDT) && (value & LCCR0_LCDT))
- printf("%s: internal frame buffer unsupported\n", __func__);
-
+ if (!(s->control[0] & LCCR0_LCDT) && (value & LCCR0_LCDT)) {
+ qemu_log_mask(LOG_UNIMP,
+ "%s: internal frame buffer unsupported\n", __func__);
+ }
if ((s->control[3] & LCCR3_API) &&
(value & LCCR0_ENB) && !(value & LCCR0_LCDT))
s->status[0] |= LCSR0_ABC;
@@ -462,9 +463,9 @@ static void pxa2xx_lcdc_write(void *opaque, hwaddr offset,
break;
case OVL1C1:
- if (!(s->ovl1c[0] & OVLC1_EN) && (value & OVLC1_EN))
- printf("%s: Overlay 1 not supported\n", __func__);
-
+ if (!(s->ovl1c[0] & OVLC1_EN) && (value & OVLC1_EN)) {
+ qemu_log_mask(LOG_UNIMP, "%s: Overlay 1 not supported\n",
__func__);
+ }
s->ovl1c[0] = value & 0x80ffffff;
s->dma_ch[1].up = (value & OVLC1_EN) || (s->control[0] & LCCR0_SDS);
break;
@@ -474,9 +475,9 @@ static void pxa2xx_lcdc_write(void *opaque, hwaddr offset,
break;
case OVL2C1:
- if (!(s->ovl2c[0] & OVLC1_EN) && (value & OVLC1_EN))
- printf("%s: Overlay 2 not supported\n", __func__);
-
+ if (!(s->ovl2c[0] & OVLC1_EN) && (value & OVLC1_EN)) {
+ qemu_log_mask(LOG_UNIMP, "%s: Overlay 2 not supported\n",
__func__);
+ }
s->ovl2c[0] = value & 0x80ffffff;
s->dma_ch[2].up = !!(value & OVLC1_EN);
s->dma_ch[3].up = !!(value & OVLC1_EN);
@@ -488,9 +489,10 @@ static void pxa2xx_lcdc_write(void *opaque, hwaddr offset,
break;
case CCR:
- if (!(s->ccr & CCR_CEN) && (value & CCR_CEN))
- printf("%s: Hardware cursor unimplemented\n", __func__);
-
+ if (!(s->ccr & CCR_CEN) && (value & CCR_CEN)) {
+ qemu_log_mask(LOG_UNIMP,
+ "%s: Hardware cursor unimplemented\n", __func__);
+ }
s->ccr = value & 0x81ffffe7;
s->dma_ch[5].up = !!(value & CCR_CEN);
break;
--
2.18.4
- [PULL 15/21] sm501: Convert printf + abort to qemu_log_mask, (continued)
- [PULL 15/21] sm501: Convert printf + abort to qemu_log_mask, Gerd Hoffmann, 2020/05/28
- [PULL 06/21] hw/display/cirrus_vga: Convert debug printf() to trace event, Gerd Hoffmann, 2020/05/28
- [PULL 16/21] sm501: Shorten long variable names in sm501_2d_operation, Gerd Hoffmann, 2020/05/28
- [PULL 21/21] sm501: Remove obsolete changelog and todo comment, Gerd Hoffmann, 2020/05/28
- [PULL 10/21] hw/display/vmware_vga: Replace printf() calls by qemu_log_mask(ERROR), Gerd Hoffmann, 2020/05/28
- [PULL 20/21] sm501: Optimize small overlapping blits, Gerd Hoffmann, 2020/05/28
- [PULL 17/21] sm501: Use BIT(x) macro to shorten constant, Gerd Hoffmann, 2020/05/28
- [PULL 12/21] hw/display/exynos4210_fimd: Use qemu_log_mask(GUEST_ERROR), Gerd Hoffmann, 2020/05/28
- [PULL 11/21] hw/display/vmware_vga: Let the PCI device own its I/O MemoryRegion, Gerd Hoffmann, 2020/05/28
- [PULL 18/21] sm501: Clean up local variables in sm501_2d_operation, Gerd Hoffmann, 2020/05/28
- [PULL 14/21] hw/display/pxa2xx_lcd: Replace printf() call by qemu_log_mask(),
Gerd Hoffmann <=
- [PULL 07/21] hw/display/dpcd: Fix memory region size, Gerd Hoffmann, 2020/05/28
- [PULL 09/21] hw/display/xlnx_dp: Replace disabled DPRINTF() by error_report(), Gerd Hoffmann, 2020/05/28
- [PULL 01/21] hw/display/edid: Add missing 'qdev-properties.h' header, Gerd Hoffmann, 2020/05/28
- [PULL 05/21] hw/display/cirrus_vga: Use qemu_log_mask(ERROR) instead of debug printf, Gerd Hoffmann, 2020/05/28
- Re: [PULL 00/21] Vga 20200528 patches, no-reply, 2020/05/28
- Re: [PULL 00/21] Vga 20200528 patches, Peter Maydell, 2020/05/29