[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/22] target/arm: Implement VFP fp16 for VFP_BINOP operation
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 03/22] target/arm: Implement VFP fp16 for VFP_BINOP operations |
|
Date: |
Tue, 25 Aug 2020 11:14:11 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/24/20 7:29 AM, Peter Maydell wrote:
> +DEF_HELPER_3(vfp_addh, f32, f32, f32, ptr)
We do have an f16 entry in helper-head.h, for documentation purposes. It
expands to the same uint32_t, so it doesn't make any practical difference.
> +float32 VFP_HELPER(name, h)(float32 a, float32 b, void *fpstp) \
And here it would be better to use uint32_t explicitly, because we're
definitely not returning float32.
I guess you could see if dh_ctype_f16 works here? But that looks a bit ugly to
me. Perhaps we should have introduced a better typedef somewhere...
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH 00/22] target/arm: Implement fp16 for AArch32 VFP, Peter Maydell, 2020/08/24
- [PATCH 01/22] target/arm: Remove local definitions of float constants, Peter Maydell, 2020/08/24
- [PATCH 02/22] target/arm: Use correct ID register check for aa32_fp16_arith, Peter Maydell, 2020/08/24
- [PATCH 03/22] target/arm: Implement VFP fp16 for VFP_BINOP operations, Peter Maydell, 2020/08/24
- Re: [PATCH 03/22] target/arm: Implement VFP fp16 for VFP_BINOP operations,
Richard Henderson <=
- [PATCH 05/22] target/arm: Macroify trans functions for VFMA, VFMS, VFNMA, VFNMS, Peter Maydell, 2020/08/24
- [PATCH 04/22] target/arm: Implement VFP fp16 VMLA, VMLS, VNMLS, VNMLA, VNMUL, Peter Maydell, 2020/08/24
- [PATCH 06/22] target/arm: Implement VFP fp16 for fused-multiply-add, Peter Maydell, 2020/08/24
- [PATCH 07/22] target/arm: Macroify uses of do_vfp_2op_sp() and do_vfp_2op_dp(), Peter Maydell, 2020/08/24
- [PATCH 08/22] target/arm: Implement VFP fp16 for VABS, VNEG, VSQRT, Peter Maydell, 2020/08/24