[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/22] target/arm: Make VFP_CONV_FIX macros take separate flo
From: |
Richard Henderson |
Subject: |
Re: [PATCH 13/22] target/arm: Make VFP_CONV_FIX macros take separate float type and float size |
Date: |
Tue, 25 Aug 2020 11:47:19 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/24/20 7:29 AM, Peter Maydell wrote:
> Currently the VFP_CONV_FIX macros take a single fsz argument for the
> size of the float type, which is used both to select the name of
> the functions to call (eg float32_is_any_nan()) and also for the
> type to use for the float inputs and outputs (eg float32).
>
> Separate these into fsz and ftype arguments, so that we can use them
> for fp16, which uses 'float16' in the function names but is still
> passing inputs and outputs in a 32-bit sized type.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/vfp_helper.c | 46 ++++++++++++++++++++---------------------
> 1 file changed, 23 insertions(+), 23 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- Re: [PATCH 10/22] target/arm: Implement VFP fp16 VCMP, (continued)
- [PATCH 11/22] target/arm: Implement VFP fp16 VLDR and VSTR, Peter Maydell, 2020/08/24
- [PATCH 12/22] target/arm: Implement VFP fp16 VCVT between float and integer, Peter Maydell, 2020/08/24
- [PATCH 15/22] target/arm: Implement VFP fp16 VCVT between float and fixed-point, Peter Maydell, 2020/08/24
- [PATCH 14/22] target/arm: Use macros instead of open-coding fp16 conversion helpers, Peter Maydell, 2020/08/24
- [PATCH 13/22] target/arm: Make VFP_CONV_FIX macros take separate float type and float size, Peter Maydell, 2020/08/24
- Re: [PATCH 13/22] target/arm: Make VFP_CONV_FIX macros take separate float type and float size,
Richard Henderson <=
- [PATCH 16/22] target/arm: Implement VFP vp16 VCVT-with-specified-rounding-mode, Peter Maydell, 2020/08/24
- [PATCH 17/22] target/arm: Implement VFP fp16 VSEL, Peter Maydell, 2020/08/24
- [PATCH 18/22] target/arm: Implement VFP fp16 VRINT*, Peter Maydell, 2020/08/24
- [PATCH 19/22] target/arm: Implement new VFP fp16 insn VINS, Peter Maydell, 2020/08/24
- [PATCH 20/22] target/arm: Implement new VFP fp16 insn VMOVX, Peter Maydell, 2020/08/24