[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 03/10] target/arm/translate-a64:Remove dead assignment in
From: |
Chenqun (kuhn) |
Subject: |
RE: [PATCH v2 03/10] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli() |
Date: |
Wed, 26 Aug 2020 02:42:37 +0000 |
> On Tue, 25 Aug 2020 at 12:26, Chen Qun <kuhn.chenqun@huawei.com> wrote:
> >
> > Clang static code analyzer show warning:
> > target/arm/translate-a64.c:8635:14: warning: Value stored to 'tcg_rn'
> > during its initialization is never read
> > TCGv_i64 tcg_rn = new_tmp_a64(s);
> > ^~~~~~ ~~~~~~~~~~~~~~
> > target/arm/translate-a64.c:8636:14: warning: Value stored to 'tcg_rd'
> > during its initialization is never read
> > TCGv_i64 tcg_rd = new_tmp_a64(s);
> > ^~~~~~ ~~~~~~~~~~~~~~
> >
> > There is a memory leak for the variable new_tmp_a64 "s".
>
> There is not, because TCG temps allocated via new_tmp_a64() are all freed via
> free_tmp_a64() at the end of disas_a64_insn().
>
OK, I'll delete that description later.
Thanks,
ChenQun