[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 5/8] mips/cps: Use start-powered-off CPUState property
From: |
Thiago Jung Bauermann |
Subject: |
[PATCH v7 5/8] mips/cps: Use start-powered-off CPUState property |
Date: |
Wed, 26 Aug 2020 02:55:32 -0300 |
Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the
start-powered-off property which makes cpu_common_reset() initialize it
to 1 in common code.
Also change creation of CPU object from cpu_create() to object_new() and
qdev_realize_and_unref() because cpu_create() realizes the CPU and it's not
possible to set a property after the object is realized.
Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
---
hw/mips/cps.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/hw/mips/cps.c b/hw/mips/cps.c
index 615e1a1ad2..23c0f87e41 100644
--- a/hw/mips/cps.c
+++ b/hw/mips/cps.c
@@ -52,9 +52,6 @@ static void main_cpu_reset(void *opaque)
CPUState *cs = CPU(cpu);
cpu_reset(cs);
-
- /* All VPs are halted on reset. Leave powering up to CPC. */
- cs->halted = 1;
}
static bool cpu_mips_itu_supported(CPUMIPSState *env)
@@ -76,7 +73,17 @@ static void mips_cps_realize(DeviceState *dev, Error **errp)
bool saar_present = false;
for (i = 0; i < s->num_vp; i++) {
- cpu = MIPS_CPU(cpu_create(s->cpu_type));
+ cpu = MIPS_CPU(object_new(s->cpu_type));
+
+ /* All VPs are halted on reset. Leave powering up to CPC. */
+ if (!object_property_set_bool(OBJECT(cpu), "start-powered-off", true,
+ errp)) {
+ return;
+ }
+
+ if (!qdev_realize_and_unref(DEVICE(cpu), NULL, errp)) {
+ return;
+ }
/* Init internal devices */
cpu_mips_irq_init_cpu(cpu);
- [PATCH v7 0/8] Generalize start-powered-off property from ARM, Thiago Jung Bauermann, 2020/08/26
- [PATCH v7 1/8] target/arm: Move start-powered-off property to generic CPUState, Thiago Jung Bauermann, 2020/08/26
- [PATCH v7 2/8] target/arm: Move setting of CPU halted state to generic code, Thiago Jung Bauermann, 2020/08/26
- [PATCH v7 3/8] ppc/spapr: Use start-powered-off CPUState property, Thiago Jung Bauermann, 2020/08/26
- [PATCH v7 4/8] ppc/e500: Use start-powered-off CPUState property, Thiago Jung Bauermann, 2020/08/26
- [PATCH v7 5/8] mips/cps: Use start-powered-off CPUState property,
Thiago Jung Bauermann <=
- [PATCH v7 6/8] sparc/sun4m: Don't set cs->halted = 0 in main_cpu_reset(), Thiago Jung Bauermann, 2020/08/26
- [PATCH v7 7/8] sparc/sun4m: Use start-powered-off CPUState property, Thiago Jung Bauermann, 2020/08/26
- [PATCH v7 8/8] target/s390x: Use start-powered-off CPUState property, Thiago Jung Bauermann, 2020/08/26
- Re: [PATCH v7 0/8] Generalize start-powered-off property from ARM, David Gibson, 2020/08/31