Re: [PATCH v6 18/20] tests/acpi: allow override blkdev

[Sergio Lopez]

On Wed, Aug 26, 2020 at 12:52:52PM +0200, Gerd Hoffmann wrote:
> microvm needs virtio-blk instead of ide.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  tests/qtest/bios-tables-test.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Sergio Lopez <slp@redhat.com>


> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index d25ff354921f..058ba3886659 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -72,6 +72,7 @@ typedef struct {
>      const char *variant;
>      const char *uefi_fl1;
>      const char *uefi_fl2;
> +    const char *blkdev;
>      const char *cd;
>      const uint64_t ram_start;
>      const uint64_t scan_len;
> @@ -635,9 +636,10 @@ static void test_acpi_one(const char *params, test_data 
> *data)
>          args = g_strdup_printf("-machine %s,kernel-irqchip=off %s -accel tcg 
> "
>              "-net none -display none %s "
>              "-drive id=hd0,if=none,file=%s,format=raw "
> -            "-device ide-hd,drive=hd0 ",
> +            "-device %s,drive=hd0 ",
>               data->machine, data->tcg_only ? "" : "-accel kvm",
> -             params ? params : "", disk);
> +             params ? params : "", disk,
> +             data->blkdev ?: "ide-hd");
>      }
>  
>      data->qts = qtest_init(args);
> -- 
> 2.27.0
>

signature.asc
Description: PGP signature