[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/6] hw/misc: Add npcm7xx random number generator
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 4/6] hw/misc: Add npcm7xx random number generator |
Date: |
Mon, 2 Nov 2020 11:36:29 +0000 |
On Fri, 23 Oct 2020 at 22:06, Havard Skinnemoen <hskinnemoen@google.com> wrote:
>
> The RNG module returns a byte of randomness when the Data Valid bit is
> set.
>
> This implementation ignores the prescaler setting, and loads a new value
> into RNGD every time RNGCS is read while the RNG is enabled and random
> data is available.
>
> A qtest featuring some simple randomness tests is included.
> +int main(int argc, char **argv)
> +{
> + int ret;
> +
> + g_test_init(&argc, &argv, NULL);
> + g_test_set_nonfatal_assertions();
While I was looking at this test case I noticed that it
calls g_test_set_nonfatal_assertions(). Why does it do that?
In our entire set of tests, only the npcm7xx test cases call
that function, and they don't explain why they're a special
case that needs to do so.
thanks
-- PMM
- Re: [PATCH v3 4/6] hw/misc: Add npcm7xx random number generator,
Peter Maydell <=