[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2] hw/display/omap_lcdc: Fix potential NULL pointer derefere
From: |
Peter Maydell |
Subject: |
Re: [PATCH V2] hw/display/omap_lcdc: Fix potential NULL pointer dereference |
Date: |
Mon, 2 Nov 2020 12:01:36 +0000 |
On Sat, 31 Oct 2020 at 03:35, AlexChen <alex.chen@huawei.com> wrote:
>
> In omap_lcd_interrupts(), the pointer omap_lcd is dereferinced before
> being check if it is valid, which may lead to NULL pointer dereference.
> So move the assignment to surface after checking that the omap_lcd is valid
> and move surface_bits_per_pixel(surface) to after the surface assignment.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: AlexChen <alex.chen@huawei.com>
> ---
> hw/display/omap_lcdc.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
Applied to target-arm.next, thanks.
-- PMM
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH V2] hw/display/omap_lcdc: Fix potential NULL pointer dereference,
Peter Maydell <=