[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V3] hw/display/exynos4210_fimd: Fix potential NULL pointer de
From: |
Peter Maydell |
Subject: |
Re: [PATCH V3] hw/display/exynos4210_fimd: Fix potential NULL pointer dereference |
Date: |
Mon, 2 Nov 2020 12:02:37 +0000 |
On Mon, 2 Nov 2020 at 10:13, AlexChen <alex.chen@huawei.com> wrote:
>
> In exynos4210_fimd_update(), the pointer 's' is dereferenced before
> checking it is valid, which may lead to NULL pointer dereference.
> So move the assignment to global_width after checking 's' is valid.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Alex Chen <alex.chen@huawei.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/display/exynos4210_fimd.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied to target-arm.next, thanks.
-- PMM