[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] docs: add some notes on the sbsa-ref machine
From: |
Peter Maydell |
Subject: |
Re: [RFC PATCH] docs: add some notes on the sbsa-ref machine |
Date: |
Tue, 3 Nov 2020 12:00:09 +0000 |
On Tue, 3 Nov 2020 at 10:47, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> We should at least document what this machine is about.
typo and grammar nits only:
> +Supported devices
> +"""""""""""""""""
> +
> +The sbsa-ref board supports:
> +
> + - A configurable number of Cortex-A57 cpus
"CPUs"
(Also if you take Leif's suggestion, "AArch64" not "aarch64".)
> + - GIC version 3
> + - System bus AHCI controller.
> + - System bus EHCI controller.
Can we be consistent about either ending with a full stop or not
in this list? I think the usual style is not to.
> + - CDROM and hard disc on AHCI bus.
> + - E1000E ethernet card on PCIE bus.
> + - VGA display adaptor on PCIE bus.
"PCIe"
> + - A generic SBSA watchdog device
thanks
-- PMM