Re: [PATCH] arm/monitor: Add support for 'info tlb' command

[no-reply]

Patchew URL: 
20201113095854.67668-1-changbin.du@gmail.com/">https://patchew.org/QEMU/20201113095854.67668-1-changbin.du@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20201113095854.67668-1-changbin.du@gmail.com
Type: series
Subject: [PATCH] arm/monitor: Add support for 'info tlb' command

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201113095854.67668-1-changbin.du@gmail.com -> 
patchew/20201113095854.67668-1-changbin.du@gmail.com
Switched to a new branch 'test'
a33e6e7 arm/monitor: Add support for 'info tlb' command

=== OUTPUT BEGIN ===
WARNING: line over 80 characters
#141: FILE: target/arm/monitor.c:267:
+print_pte_lpae(Monitor *mon, uint32_t tableattrs, int va_bits, target_ulong 
vaddr,

ERROR: spaces required around that '=' (ctx:VxW)
#174: FILE: target/arm/monitor.c:300:
+    int ptshift= pg_shift + (max_level - cur_level) * stride;
                ^

WARNING: line over 80 characters
#195: FILE: target/arm/monitor.c:321:
+            print_pte_lpae(mon, tableattrs, va_bits, vstart, paddr, pgsize, 
pte);

WARNING: line over 80 characters
#268: FILE: target/arm/monitor.c:394:
+            walk_pte_lpae(mon, true, 0, base, vstart, cur_level, stride, 
va_bits);

total: 1 errors, 3 warnings, 262 lines checked

Commit a33e6e7e0edd (arm/monitor: Add support for 'info tlb' command) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201113095854.67668-1-changbin.du@gmail.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201113095854.67668-1-changbin.du@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com