[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 10/11] target/arm: Fix decode of align in VLDST_single
From: |
Richard Henderson |
Subject: |
[PATCH 10/11] target/arm: Fix decode of align in VLDST_single |
Date: |
Tue, 24 Nov 2020 20:06:41 -0800 |
The encoding of size = 2 and size = 3 had the incorrect decode
for align, overlapping the stride field. This error was hidden
by what should have been unnecessary masking in translate.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/neon-ls.decode | 4 ++--
target/arm/translate-neon.c.inc | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/arm/neon-ls.decode b/target/arm/neon-ls.decode
index c17f5019e3..0a2a0e15db 100644
--- a/target/arm/neon-ls.decode
+++ b/target/arm/neon-ls.decode
@@ -46,7 +46,7 @@ VLD_all_lanes 1111 0100 1 . 1 0 rn:4 .... 11 n:2 size:2 t:1
a:1 rm:4 \
VLDST_single 1111 0100 1 . l:1 0 rn:4 .... 00 n:2 reg_idx:3 align:1 rm:4 \
vd=%vd_dp size=0 stride=1
-VLDST_single 1111 0100 1 . l:1 0 rn:4 .... 01 n:2 reg_idx:2 align:2 rm:4 \
+VLDST_single 1111 0100 1 . l:1 0 rn:4 .... 01 n:2 reg_idx:2 . align:1 rm:4 \
vd=%vd_dp size=1 stride=%imm1_5_p1
-VLDST_single 1111 0100 1 . l:1 0 rn:4 .... 10 n:2 reg_idx:1 align:3 rm:4 \
+VLDST_single 1111 0100 1 . l:1 0 rn:4 .... 10 n:2 reg_idx:1 . align:2 rm:4 \
vd=%vd_dp size=2 stride=%imm1_6_p1
diff --git a/target/arm/translate-neon.c.inc b/target/arm/translate-neon.c.inc
index c4be019d9c..330b5fc7b0 100644
--- a/target/arm/translate-neon.c.inc
+++ b/target/arm/translate-neon.c.inc
@@ -616,7 +616,7 @@ static bool trans_VLDST_single(DisasContext *s,
arg_VLDST_single *a)
switch (nregs) {
case 1:
if (((a->align & (1 << a->size)) != 0) ||
- (a->size == 2 && ((a->align & 3) == 1 || (a->align & 3) == 2))) {
+ (a->size == 2 && (a->align == 1 || a->align == 2))) {
return false;
}
break;
@@ -631,7 +631,7 @@ static bool trans_VLDST_single(DisasContext *s,
arg_VLDST_single *a)
}
break;
case 4:
- if ((a->size == 2) && ((a->align & 3) == 3)) {
+ if (a->size == 2 && a->align == 3) {
return false;
}
break;
--
2.25.1
- [PATCH 02/11] target/arm: Enforce alignment for LDA/LDAH/STL/STLH, (continued)
- [PATCH 02/11] target/arm: Enforce alignment for LDA/LDAH/STL/STLH, Richard Henderson, 2020/11/24
- [PATCH 03/11] target/arm: Enforce alignment for LDM/STM, Richard Henderson, 2020/11/24
- [PATCH 04/11] target/arm: Enforce alignment for RFE, Richard Henderson, 2020/11/24
- [PATCH 05/11] target/arm: Enforce alignment for SRS, Richard Henderson, 2020/11/24
- [PATCH 06/11] target/arm: Enforce alignment for VLDM/VSTM, Richard Henderson, 2020/11/24
- [PATCH 07/11] target/arm: Enforce alignment for VLDR/VSTR, Richard Henderson, 2020/11/24
- [PATCH 09/11] target/arm: Enforce alignment for VLDn/VSTn (multiple), Richard Henderson, 2020/11/24
- [PATCH 08/11] target/arm: Enforce alignment for VLD1 (all lanes), Richard Henderson, 2020/11/24
- [PATCH 11/11] target/arm: Enforce alignment for VLDn/VSTn (single), Richard Henderson, 2020/11/24
- [PATCH 10/11] target/arm: Fix decode of align in VLDST_single,
Richard Henderson <=