[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 5/7] exynos4210_rtc: Use ptimer_free() in the finalize function t
From: |
Gan Qixin |
Subject: |
[PATCH 5/7] exynos4210_rtc: Use ptimer_free() in the finalize function to avoid memleaks |
Date: |
Fri, 27 Nov 2020 15:18:01 +0800 |
When running device-introspect-test, a memory leak occurred in the
exynos4210_rtc_init
function, so use ptimer_free() in the finalize function to avoid it.
ASAN shows memory leak stack:
Indirect leak of 96 byte(s) in 1 object(s) allocated from:
#0 0xffffab97e1f0 in __interceptor_calloc (/lib64/libasan.so.5+0xee1f0)
#1 0xffffab256800 in g_malloc0 (/lib64/libglib-2.0.so.0+0x56800)
#2 0xaaabf555db78 in ptimer_init /qemu/hw/core/ptimer.c:432
#3 0xaaabf57b3934 in exynos4210_rtc_init /qemu/hw/rtc/exynos4210_rtc.c:567
#4 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515
#5 0xaaabf633a1e0 in object_new_with_type /qemu/qom/object.c:729
#6 0xaaabf6375e40 in qmp_device_list_properties /qemu/qom/qom-qmp-cmds.c:153
#7 0xaaabf653d8ec in qmp_marshal_device_list_properties
/qemu/qapi/qapi-commands-qdev.c:59
#8 0xaaabf6587d08 in do_qmp_dispatch_bh /qemu/qapi/qmp-dispatch.c:110
#9 0xaaabf6552708 in aio_bh_call /qemu/util/async.c:136
#10 0xaaabf6552708 in aio_bh_poll /qemu/util/async.c:164
#11 0xaaabf655f19c in aio_dispatch /qemu/util/aio-posix.c:381
#12 0xaaabf65523f4 in aio_ctx_dispatch /qemu/util/async.c:306
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Gan Qixin <ganqixin@huawei.com>
---
Cc: Igor Mitsyanko <i.mitsyanko@gmail.com>
---
hw/rtc/exynos4210_rtc.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/hw/rtc/exynos4210_rtc.c b/hw/rtc/exynos4210_rtc.c
index 4c97624478..2f667fb010 100644
--- a/hw/rtc/exynos4210_rtc.c
+++ b/hw/rtc/exynos4210_rtc.c
@@ -584,6 +584,14 @@ static void exynos4210_rtc_init(Object *obj)
sysbus_init_mmio(dev, &s->iomem);
}
+static void exynos4210_rtc_finalize(Object *obj)
+{
+ Exynos4210RTCState *s = EXYNOS4210_RTC(obj);
+
+ ptimer_free(s->ptimer);
+ ptimer_free(s->ptimer_1Hz);
+}
+
static void exynos4210_rtc_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
@@ -593,11 +601,12 @@ static void exynos4210_rtc_class_init(ObjectClass *klass,
void *data)
}
static const TypeInfo exynos4210_rtc_info = {
- .name = TYPE_EXYNOS4210_RTC,
- .parent = TYPE_SYS_BUS_DEVICE,
- .instance_size = sizeof(Exynos4210RTCState),
- .instance_init = exynos4210_rtc_init,
- .class_init = exynos4210_rtc_class_init,
+ .name = TYPE_EXYNOS4210_RTC,
+ .parent = TYPE_SYS_BUS_DEVICE,
+ .instance_size = sizeof(Exynos4210RTCState),
+ .instance_init = exynos4210_rtc_init,
+ .instance_finalize = exynos4210_rtc_finalize,
+ .class_init = exynos4210_rtc_class_init,
};
static void exynos4210_rtc_register_types(void)
--
2.23.0
- [PATCH 0/7] Fix some memleaks caused by ptimer_init, Gan Qixin, 2020/11/27
- [PATCH 5/7] exynos4210_rtc: Use ptimer_free() in the finalize function to avoid memleaks,
Gan Qixin <=
- [PATCH 7/7] musicpal: Use ptimer_free() in the finalize function to avoid memleaks, Gan Qixin, 2020/11/27
- [PATCH 1/7] allwinner-a10-pit: Use ptimer_free() in the finalize function to avoid memleaks, Gan Qixin, 2020/11/27
- [PATCH 4/7] exynos4210_pwm: Use ptimer_free() in the finalize function to avoid memleaks, Gan Qixin, 2020/11/27
- [PATCH 3/7] exynos4210_mct: Use ptimer_free() in the finalize function to avoid memleaks, Gan Qixin, 2020/11/27
- [PATCH 2/7] digic-timer: Use ptimer_free() in the finalize function to avoid memleaks, Gan Qixin, 2020/11/27
- [PATCH 6/7] mss-timer: Use ptimer_free() in the finalize function to avoid memleaks, Gan Qixin, 2020/11/27