[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] accel: kvm: Fix memory waste under mismatch page size
From: |
Keqian Zhu |
Subject: |
Re: [PATCH 1/2] accel: kvm: Fix memory waste under mismatch page size |
Date: |
Thu, 17 Dec 2020 09:03:24 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 |
On 2020/12/17 4:48, Peter Xu wrote:
> On Wed, Dec 16, 2020 at 04:21:17PM +0800, Keqian Zhu wrote:
>> One more thing, we should consider whether @start and @size is psize aligned
>> (my second
>> patch). Do you agree to add assert on them directly?
>
> Yes I think the 2nd patch is okay, but please address Drew's comments.
>
> Returning -EINVAL is the same as abort() currently - it'll just abort() at
> kvm_log_clear() instead.
OK, I will send v2 soon.
Thanks,
Keqian
>
> Thanks,
>
- Re: [PATCH 2/2] accel: kvm: Add aligment check for kvm_log_clear_one_slot, (continued)
[PATCH 1/2] accel: kvm: Fix memory waste under mismatch page size, Keqian Zhu, 2020/12/15