[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] hw/ssi: imx_spi: Use a macro for number of chip selec
From: |
Alistair Francis |
Subject: |
Re: [PATCH v2 1/2] hw/ssi: imx_spi: Use a macro for number of chip selects supported |
Date: |
Tue, 5 Jan 2021 13:12:19 -0800 |
On Tue, Jan 5, 2021 at 1:08 PM Alistair Francis <alistair23@gmail.com> wrote:
>
> On Wed, Dec 16, 2020 at 2:25 AM Bin Meng <bmeng.cn@gmail.com> wrote:
> >
> > Hi Alistair, Peter,
> >
> > On Wed, Dec 2, 2020 at 10:45 PM Bin Meng <bmeng.cn@gmail.com> wrote:
> > >
> > > From: Bin Meng <bin.meng@windriver.com>
> > >
> > > Avoid using a magic number (4) everywhere for the number of chip
> > > selects supported.
> > >
> > > Signed-off-by: Bin Meng <bin.meng@windriver.com>
> > > Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> > > ---
> > >
> > > (no changes since v1)
> > >
> > > hw/ssi/imx_spi.c | 4 ++--
> > > include/hw/ssi/imx_spi.h | 5 ++++-
> > > 2 files changed, 6 insertions(+), 3 deletions(-)
> > >
> >
> > Ping, not sure who is going to pick up this series?
>
> It should be reviewed by Jean-Christophe and then probably go via the ARM
> tree.
Ah, I just realised I apparently have `hw/ssi/*` listed in
MAINTAINERS. As this file is specifically mentioned somewhere else in
MAINTAINERS and I know very little about IMX I'm going to leave this
alone still.
Alistair
>
> Alistair
>
> >
> > Regards,
> > Bin
> >