[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 0/6] hw/ssi: imx_spi: Fix various bugs in the imx_spi model
From: |
Bin Meng |
Subject: |
[PATCH v4 0/6] hw/ssi: imx_spi: Fix various bugs in the imx_spi model |
Date: |
Sun, 10 Jan 2021 16:14:23 +0800 |
From: Bin Meng <bin.meng@windriver.com>
This series fixes a bunch of bugs in current implementation of the imx
spi controller, including the following issues:
- chip select signal was not lower down when spi controller is disabled
- remove imx_spi_update_irq() in imx_spi_reset()
- transfer incorrect data when the burst length is larger than 32 bit
- spi controller tx and rx fifo endianness is incorrect
Tested with upstream U-Boot v2020.10 (polling mode) and VxWorks 7
(interrupt mode).
Changes in v4:
- adujst the patch 2,3 order
- rename imx_spi_soft_reset() to imx_spi_hard_reset() to avoid confusion
- s/normal/common/ in the commit message
- log the burst length value in the log message
Changes in v3:
- new patch: remove imx_spi_update_irq() in imx_spi_reset()
- Move the chip selects disable out of imx_spi_reset()
- new patch: log unimplemented burst length
- Simplify the tx fifo endianness handling
Changes in v2:
- Fix the "Fixes" tag in the commit message
- Use ternary operator as Philippe suggested
Bin Meng (5):
hw/ssi: imx_spi: Use a macro for number of chip selects supported
hw/ssi: imx_spi: Remove imx_spi_update_irq() in imx_spi_reset()
hw/ssi: imx_spi: Log unimplemented burst length
hw/ssi: imx_spi: Correct the burst length > 32 bit transfer logic
hw/ssi: imx_spi: Correct tx and rx fifo endianness
Xuzhou Cheng (1):
hw/ssi: imx_spi: Disable chip selects when controller is disabled
include/hw/ssi/imx_spi.h | 5 ++++-
hw/ssi/imx_spi.c | 42 ++++++++++++++++++++++++++++------------
2 files changed, 34 insertions(+), 13 deletions(-)
--
2.25.1
- [PATCH v4 0/6] hw/ssi: imx_spi: Fix various bugs in the imx_spi model,
Bin Meng <=
[PATCH v4 3/6] hw/ssi: imx_spi: Disable chip selects when controller is disabled, Bin Meng, 2021/01/10