Re: [PATCH v1 12/20] semihosting: Move ARM semihosting code to shared directories

[Philippe Mathieu-Daudé]

On 1/11/21 4:30 PM, Philippe Mathieu-Daudé wrote:
> On 1/8/21 11:42 PM, Alex Bennée wrote:
>> From: Keith Packard <keithp@keithp.com>
>>
>> This commit renames two files which provide ARM semihosting support so
>> that they can be shared by other architectures:
>>
>>  1. target/arm/arm-semi.c     -> hw/semihosting/common-semi.c
>>  2. linux-user/arm/semihost.c -> linux-user/semihost.c
>>
>> The build system was modified use a new config variable,
>> CONFIG_ARM_COMPATIBLE_SEMIHOSTING, which has been added to the ARM
>> softmmu and linux-user default configs. The contents of the source
>> files has not been changed in this patch.
>>
>> Signed-off-by: Keith Packard <keithp@keithp.com>
>> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Message-Id: <20210107170717.2098982-2-keithp@keithp.com>
>> ---
>>  default-configs/devices/arm-softmmu.mak               | 1 +
>>  default-configs/targets/aarch64-linux-user.mak        | 1 +
>>  default-configs/targets/aarch64_be-linux-user.mak     | 1 +
>>  default-configs/targets/arm-linux-user.mak            | 1 +
>>  default-configs/targets/armeb-linux-user.mak          | 1 +
>>  target/arm/arm-semi.c => hw/semihosting/common-semi.c | 0
>>  linux-user/{arm => }/semihost.c                       | 0
>>  hw/semihosting/Kconfig                                | 3 +++
>>  hw/semihosting/meson.build                            | 3 +++
>>  linux-user/arm/meson.build                            | 3 ---
>>  linux-user/meson.build                                | 1 +
>>  target/arm/meson.build                                | 2 --
>>  12 files changed, 12 insertions(+), 5 deletions(-)
>>  rename target/arm/arm-semi.c => hw/semihosting/common-semi.c (100%)
>>  rename linux-user/{arm => }/semihost.c (100%)

Can we name these file with some explicit "arm_compat_semihosting"?

> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>