Re: [PATCH 07/18] target/arm: add 64-bit S-EL2 to EL exception table

[Richard Henderson]

On 12/18/20 12:37 AM, remi.denis.courmont@huawei.com wrote:
> From: Rémi Denis-Courmont <remi.denis.courmont@huawei.com>
> 
> With the ARMv8.4-SEL2 extension, EL2 is a legal exception level in
> secure mode, though it can only be AArch64.
> 
> This patch adds the target EL for exceptions from 64-bit S-EL2.
> 
> It also fixes the target EL to EL2 when HCR.{A,F,I}MO are set in secure
> mode. Those values were never used in practice as the effective value of
> HCR was always 0 in secure mode.
> 
> Signed-off-by: Rémi Denis-Courmont <remi.denis.courmont@huawei.com>
> ---
>  target/arm/helper.c    | 10 +++++-----
>  target/arm/op_helper.c |  4 ++--
>  2 files changed, 7 insertions(+), 7 deletions(-)

At some point I think it would be worthwhile to convert that target_el_table
back to code.  It is really hard to follow with 6 indicies.  Not your fault.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~