Re: [PATCH 14/18] target/arm: secure stage 2 translation regime

[Richard Henderson]

On 12/18/20 12:37 AM, remi.denis.courmont@huawei.com wrote:
> @@ -11286,8 +11299,10 @@ static bool get_phys_addr_lpae(CPUARMState *env, 
> uint64_t address,
>  
>      ap = extract32(attrs, 4, 2);
>  
> -    if (mmu_idx == ARMMMUIdx_Stage2) {
> -        ns = true;
> +    if (mmu_idx == ARMMMUIdx_Stage2 || mmu_idx == ARMMMUIdx_Stage2_S) {
> +        if (mmu_idx == ARMMMUIdx_Stage2) {
> +            ns = true;
> +        }
>          xn = extract32(attrs, 11, 2);

Does this want an unconditional

  ns = mmu_idx == ARMMMUIdx_Stage2;

When can ns be true and mmu_idx == ARMMMUIdx_Stage2_S?

Otherwise,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~