[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/4] target/arm: Introduce PREDDESC field definitions
From: |
Richard Henderson |
Subject: |
[PATCH v2 1/4] target/arm: Introduce PREDDESC field definitions |
Date: |
Tue, 12 Jan 2021 20:26:47 -1000 |
SVE predicate operations cannot use the "usual" simd_desc
encoding, because the lengths are not a multiple of 8.
But we were abusing the SIMD_* fields to store values anyway.
This abuse broke when SIMD_OPRSZ_BITS was modified in e2e7168a214.
Introduce a new set of field definitions for exclusive use
of predicates, so that it is obvious what kind of predicate
we are manipulating. To be used in future patches.
Cc: qemu-stable@nongnu.org
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/internals.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/target/arm/internals.h b/target/arm/internals.h
index 5460678756..73698587d6 100644
--- a/target/arm/internals.h
+++ b/target/arm/internals.h
@@ -1312,6 +1312,15 @@ void arm_log_exception(int idx);
#define LOG2_TAG_GRANULE 4
#define TAG_GRANULE (1 << LOG2_TAG_GRANULE)
+/*
+ * SVE predicates are 1/8 the size of SVE vectors, and cannot use
+ * the same simd_desc() encoding due to restrictions on size.
+ * Use these instead.
+ */
+FIELD(PREDDESC, OPRSZ, 0, 6)
+FIELD(PREDDESC, ESZ, 6, 2)
+FIELD(PREDDESC, DATA, 8, 24)
+
/*
* The SVE simd_data field, for memory ops, contains either
* rd (5 bits) or a shift count (2 bits).
--
2.25.1
- [PATCH v2 0/4] target/arm: Fix sve pred_desc decoding, Richard Henderson, 2021/01/13
- [PATCH v2 1/4] target/arm: Introduce PREDDESC field definitions,
Richard Henderson <=
- [PATCH v2 2/4] target/arm: Update PFIRST, PNEXT for pred_desc, Richard Henderson, 2021/01/13
- [PATCH v2 3/4] target/arm: Update ZIP, UZP, TRN for pred_desc, Richard Henderson, 2021/01/13
- [PATCH v2 4/4] target/arm: Update REV, PUNPK for pred_desc, Richard Henderson, 2021/01/13
- Re: [PATCH v2 0/4] target/arm: Fix sve pred_desc decoding, Peter Maydell, 2021/01/19