Re: [PATCHv6 0/3] arm-virt: add secure pl061 for reset/power down

[Andrew Jones]

On Thu, Jan 14, 2021 at 05:50:29PM +0300, Maxim Uvarov wrote:
>  v6: - 64k align gpio memory region (Andrew Jones)
>      - adjusted memory region to map this address in the corresponding atf 
> patch
>  v5: - removed vms flag, added fdt  (Andrew Jones)
>      - added patch3 to combine secure and non secure pl061. It has to be

I think you should do non-functional change refactoring in patch 2 and
then add the device with the DTB updates in patch 3.

Thanks,
drew


>        more easy to review if this changes are in the separate patch.
>  v4: rework patches accodring to Peter Maydells comments:
>       - split patches on gpio-pwr driver and arm-virt integration.
>       - start secure gpio only from virt-6.0.
>       - rework qemu interface for gpio-pwr to use 2 named gpio.
>       - put secure gpio to secure name space.
>  v3: added missed include qemu/log.h for qemu_log(.. 
>  v2: replace printf with qemu_log (Philippe Mathieu-Daudé)
> 
> This patch works together with ATF patch:
>       
> https://github.com/muvarov/arm-trusted-firmware/commit/7556d07e87f755c602cd9d90359341bdd14d9d57
> 
> Previus discussion for reboot issue was here:
>      https://www.mail-archive.com/qemu-devel@nongnu.org/msg757705.html
> 
> Maxim Uvarov (3):
>   hw: gpio: implement gpio-pwr driver for qemu reset/poweroff
>   arm-virt: add secure pl061 for reset/power down
>   arm-virt: combine code for secure and non secure pl061
> 
>  hw/arm/Kconfig        |   1 +
>  hw/arm/virt.c         | 118 +++++++++++++++++++++++++++++++++++-------
>  hw/gpio/Kconfig       |   3 ++
>  hw/gpio/gpio_pwr.c    |  70 +++++++++++++++++++++++++
>  hw/gpio/meson.build   |   1 +
>  include/hw/arm/virt.h |   2 +
>  6 files changed, 175 insertions(+), 20 deletions(-)
>  create mode 100644 hw/gpio/gpio_pwr.c
> 
> -- 
> 2.17.1
>