[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 7/9] hw/ssi: imx_spi: Round up the burst length to be multiple
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v7 7/9] hw/ssi: imx_spi: Round up the burst length to be multiple of 8 |
Date: |
Fri, 15 Jan 2021 16:30:47 +0100 |
From: Bin Meng <bin.meng@windriver.com>
Current implementation of the imx spi controller expects the burst
length to be multiple of 8, which is the most common use case.
In case the burst length is not what we expect, log it to give user
a chance to notice it, and round it up to be multiple of 8.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Message-Id: <20210112145526.31095-5-bmeng.cn@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/ssi/imx_spi.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c
index c132f99ba5b..b79304d93d9 100644
--- a/hw/ssi/imx_spi.c
+++ b/hw/ssi/imx_spi.c
@@ -128,7 +128,20 @@ static uint8_t imx_spi_selected_channel(IMXSPIState *s)
static uint32_t imx_spi_burst_length(IMXSPIState *s)
{
- return EXTRACT(s->regs[ECSPI_CONREG], ECSPI_CONREG_BURST_LENGTH) + 1;
+ uint32_t burst;
+
+ burst = EXTRACT(s->regs[ECSPI_CONREG], ECSPI_CONREG_BURST_LENGTH) + 1;
+ if (burst % 8) {
+ qemu_log_mask(LOG_UNIMP,
+ "[%s]%s: burst length (%d) not multiple of 8!\n",
+ TYPE_IMX_SPI, __func__, burst);
+ burst = ROUND_UP(burst, 8);
+ qemu_log_mask(LOG_UNIMP,
+ "[%s]%s: burst length rounded up to %d; this may not
work.\n",
+ TYPE_IMX_SPI, __func__, burst);
+ }
+
+ return burst;
}
static bool imx_spi_is_enabled(IMXSPIState *s)
--
2.26.2
- [PATCH v7 4/9] hw/ssi: imx_spi: Rework imx_spi_read() to handle block disabled, (continued)
[PATCH v7 6/9] hw/ssi: imx_spi: Disable chip selects when controller is disabled, Philippe Mathieu-Daudé, 2021/01/15
[PATCH v7 7/9] hw/ssi: imx_spi: Round up the burst length to be multiple of 8,
Philippe Mathieu-Daudé <=
[PATCH v7 8/9] hw/ssi: imx_spi: Correct the burst length > 32 bit transfer logic, Philippe Mathieu-Daudé, 2021/01/15
[PATCH v7 9/9] hw/ssi: imx_spi: Correct tx and rx fifo endianness, Philippe Mathieu-Daudé, 2021/01/15
Re: [PATCH v7 0/9] hw/ssi: imx_spi: Fix various bugs in the imx_spi model, Bin Meng, 2021/01/16