[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 07/21] linux-user: Tidy VERIFY_READ/VERIFY_WRITE
From: |
Richard Henderson |
Subject: |
[PATCH v3 07/21] linux-user: Tidy VERIFY_READ/VERIFY_WRITE |
Date: |
Fri, 15 Jan 2021 12:46:31 -1000 |
These constants are only ever used with access_ok, and friends.
Rather than translating them to PAGE_* bits, let them equal
the PAGE_* bits to begin.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/qemu.h | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index a0f670832e..329a6de669 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -486,8 +486,8 @@ extern unsigned long guest_stack_size;
/* user access */
-#define VERIFY_READ 0
-#define VERIFY_WRITE 1 /* implies read access */
+#define VERIFY_READ PAGE_READ
+#define VERIFY_WRITE (PAGE_READ | PAGE_WRITE)
static inline bool access_ok(int type, abi_ulong addr, abi_ulong size)
{
@@ -499,9 +499,7 @@ static inline bool access_ok(int type, abi_ulong addr,
abi_ulong size)
!guest_addr_valid(addr + size - 1))) {
return false;
}
- return page_check_range((target_ulong)addr, size,
- (type == VERIFY_READ) ? PAGE_READ :
- (PAGE_READ | PAGE_WRITE)) == 0;
+ return page_check_range((target_ulong)addr, size, type) == 0;
}
/* NOTE __get_user and __put_user use host pointers and don't check access.
--
2.25.1
- Re: [PATCH v3 03/21] exec: Use uintptr_t for guest_base, (continued)
- [PATCH v3 04/21] exec: Use uintptr_t in cpu_ldst.h, Richard Henderson, 2021/01/15
- [PATCH v3 05/21] exec: Improve types for guest_addr_valid, Richard Henderson, 2021/01/15
- [PATCH v3 10/21] linux-user: Fix guest_addr_valid vs reserved_va, Richard Henderson, 2021/01/15
- [PATCH v3 08/21] bsd-user: Tidy VERIFY_READ/VERIFY_WRITE, Richard Henderson, 2021/01/15
- [PATCH v3 07/21] linux-user: Tidy VERIFY_READ/VERIFY_WRITE,
Richard Henderson <=
- [PATCH v3 09/21] linux-user: Do not use guest_addr_valid for h2g_valid, Richard Henderson, 2021/01/15
- [PATCH v3 06/21] linux-user: Check for overflow in access_ok, Richard Henderson, 2021/01/15
- [PATCH v3 11/21] exec: Add support for TARGET_TAGGED_ADDRESSES, Richard Henderson, 2021/01/15
- [PATCH v3 12/21] linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE, Richard Henderson, 2021/01/15