Re: [RFC PATCH 0/4] hw/intc: enable GICv4 memory layout for GICv3 driver

[no-reply]

Patchew URL: 20210124025306.3949-1-leif@nuviainc.com/">https://patchew.org/QEMU/20210124025306.3949-1-leif@nuviainc.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210124025306.3949-1-leif@nuviainc.com
Subject: [RFC PATCH 0/4] hw/intc: enable GICv4 memory layout for GICv3 driver

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      
patchew/20210123230105.2076270-1-richard.henderson@linaro.org -> 
patchew/20210123230105.2076270-1-richard.henderson@linaro.org
 * [new tag]         patchew/20210124025306.3949-1-leif@nuviainc.com -> 
patchew/20210124025306.3949-1-leif@nuviainc.com
Switched to a new branch 'test'
22ce3eb hw/intc: make gicv3_idreg() distinguish between gicv3/gicv4
4d2400c hw/intc: set GICD_TYPER.DVIS for GICv4
bab9208 hw/intc: add helper function to determine gicv3 redistributor size
71fa48f hw/intc: don't bail out gicv3 model init for revision 4

=== OUTPUT BEGIN ===
1/4 Checking commit 71fa48fa1624 (hw/intc: don't bail out gicv3 model init for 
revision 4)
2/4 Checking commit bab920855fbe (hw/intc: add helper function to determine 
gicv3 redistributor size)
3/4 Checking commit 4d2400cda07b (hw/intc: set GICD_TYPER.DVIS for GICv4)
ERROR: superfluous trailing semicolon
#25: FILE: hw/intc/arm_gicv3_dist.c:391:
+            *data |= (1 << 18);;

total: 1 errors, 0 warnings, 9 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/4 Checking commit 22ce3eb6f90a (hw/intc: make gicv3_idreg() distinguish 
between gicv3/gicv4)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210124025306.3949-1-leif@nuviainc.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210124025306.3949-1-leif@nuviainc.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com