[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 19/25] hw/timer/cmsdk-apb-dualtimer: Convert to use Clock inp
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 19/25] hw/timer/cmsdk-apb-dualtimer: Convert to use Clock input |
|
Date: |
Wed, 27 Jan 2021 23:00:03 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/21/21 8:06 PM, Peter Maydell wrote:
> Switch the CMSDK APB dualtimer device over to using its Clock input;
> the pclk-frq property is now ignored.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/timer/cmsdk-apb-dualtimer.c | 42 ++++++++++++++++++++++++++++++----
> 1 file changed, 37 insertions(+), 5 deletions(-)
...
> @@ -454,8 +486,8 @@ static void cmsdk_apb_dualtimer_realize(DeviceState *dev,
> Error **errp)
> CMSDKAPBDualTimer *s = CMSDK_APB_DUALTIMER(dev);
> int i;
>
> - if (s->pclk_frq == 0) {
> - error_setg(errp, "CMSDK APB timer: pclk-frq property must be set");
> + if (!clock_has_source(s->timclk)) {
> + error_setg(errp, "CMSDK APB dualtimer: TIMCLK clock must be
> connected");
> return;
> }
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
[PATCH 20/25] hw/watchdog/cmsdk-apb-watchdog: Convert to use Clock input, Peter Maydell, 2021/01/21
[PATCH 21/25] tests/qtest/cmsdk-apb-watchdog-test: Test clock changes, Peter Maydell, 2021/01/21