[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/6] hw/i2c: Implement NPCM7XX SMBus Module FIFO Mode
From: |
Corey Minyard |
Subject: |
Re: [PATCH 6/6] hw/i2c: Implement NPCM7XX SMBus Module FIFO Mode |
Date: |
Wed, 27 Jan 2021 23:36:32 -0600 |
On Wed, Jan 27, 2021 at 05:37:25PM -0600, Corey Minyard wrote:
> On Wed, Jan 27, 2021 at 01:59:07PM -0800, Hao Wu wrote:
> > >
> > > There is also the question about who takes these patches in. I'm the
> > > I2C maintainer, but there's other code in this series. Once everything
> > > is ready, I can ack them if we take it through the ARM tree. Or I can
> > > take it through my tree with the proper acks.
> > >
> > I think either way is fine. Previous NPCM7XX patch series were taken in
> > the ARM tree. But as i2c code taking into your tree is also fine.
> >
Let's go through the ARM tree, then. So you have an:
Acked-by: Corey Minyard <cminyard@mvista.com>
For patches 2 and 6.
Patch 4 still has the issue with the eeprom size. If you are expecting
a 32K eeprom to work, it's not going to, you are only going to get 256
bytes.
-corey
- Re: [PATCH 3/6] hw/arm: Add I2C device tree for NPCM750 eval board, (continued)
[PATCH 5/6] hw/i2c: Add a QTest for NPCM7XX SMBus Device, Hao Wu, 2021/01/26