[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/7] hw/arm/xlnx-zcu102: Restrict ZynqMP ZCU102 board to 6
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 6/7] hw/arm/xlnx-zcu102: Restrict ZynqMP ZCU102 board to 64-bit build |
Date: |
Sun, 31 Jan 2021 13:31:57 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/31/21 11:59 AM, Philippe Mathieu-Daudé wrote:
> The ZynqMP ZCU102 board only use the Cortex-A53 CPU, which
> is only available in the 64-bit build. It is pointless to
> have this board present in the 32-bit build where this CPU
> is not available.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Cc: Alistair Francis <alistair@alistair23.me>
> Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
> ---
> hw/arm/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/meson.build b/hw/arm/meson.build
> index 059ff7382f2..345099f5a1b 100644
> --- a/hw/arm/meson.build
> +++ b/hw/arm/meson.build
> @@ -41,7 +41,7 @@
> arm_ss.add(when: 'CONFIG_RASPI', if_true: files('bcm2835_peripherals.c',
> 'bcm2836.c', 'raspi.c'))
> arm_ss.add(when: 'CONFIG_STM32F205_SOC', if_true: files('stm32f205_soc.c'))
> arm_ss.add(when: 'CONFIG_STM32F405_SOC', if_true: files('stm32f405_soc.c'))
> -arm_ss.add(when: 'CONFIG_XLNX_ZYNQMP_ARM', if_true: files('xlnx-zynqmp.c',
> 'xlnx-zcu102.c'))
> +arm_ss.add(when: ['CONFIG_XLNX_ZYNQMP_ARM', 'TARGET_AARCH64'], if_true:
> files('xlnx-zynqmp.c', 'xlnx-zcu102.c'))
Please disregard this patch, it shows that my other patch
"meson: Introduce target-specific Kconfig" is incorrect:
https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg07989.html
Probably because per docs/devel/kconfig.rst "devices are usually
``default y`` if and only if they have at least one ``depends on``".
I'll try another approach such:
-- >8 --
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -389,6 +391,8 @@ config XLNX_ZYNQMP_ARM
config XLNX_VERSAL
bool
+ default y
+ depends on AARCH64
select ARM_GIC
select PL011
select CADENCE
---
- [PATCH v2 0/7] hw/arm: Misc trivial fixes/cleanups, Philippe Mathieu-Daudé, 2021/01/31
- [PATCH v2 1/7] hw/arm/stm32f405_soc: Add missing dependency on OR_IRQ, Philippe Mathieu-Daudé, 2021/01/31
- [PATCH v2 2/7] hw/arm/exynos4210: Add missing dependency on OR_IRQ, Philippe Mathieu-Daudé, 2021/01/31
- [PATCH v2 3/7] hw/arm/xlnx-versal: Versal SoC requires ZDMA, Philippe Mathieu-Daudé, 2021/01/31
- [PATCH v2 4/7] hw/arm/virt: Do not include 64-bit CPUs in 32-bit build, Philippe Mathieu-Daudé, 2021/01/31
- [PATCH v2 5/7] hw/arm/sbsa-ref: Restrict SBSA-ref board to 64-bit build, Philippe Mathieu-Daudé, 2021/01/31
- [PATCH v2 6/7] hw/arm/xlnx-zcu102: Restrict ZynqMP ZCU102 board to 64-bit build, Philippe Mathieu-Daudé, 2021/01/31
- Re: [PATCH v2 6/7] hw/arm/xlnx-zcu102: Restrict ZynqMP ZCU102 board to 64-bit build,
Philippe Mathieu-Daudé <=
- [PATCH v2 7/7] hw/arm: Display CPU type in machine description, Philippe Mathieu-Daudé, 2021/01/31