[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] target/arm: Don't migrate CPUARMState.features
From: |
Aaron Lindsay |
Subject: |
[PATCH] target/arm: Don't migrate CPUARMState.features |
Date: |
Wed, 3 Feb 2021 11:13:40 -0500 |
As feature flags are added or removed, the meanings of bits in the
`features` field can change between QEMU versions, causing migration
failures. Additionally, migrating the field is not useful because it is
a constant function of the CPU being used.
Signed-off-by: Aaron Lindsay <aaron@os.amperecomputing.com>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
---
target/arm/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/machine.c b/target/arm/machine.c
index c9e9fd0a12..7f2511b6ed 100644
--- a/target/arm/machine.c
+++ b/target/arm/machine.c
@@ -834,7 +834,7 @@ const VMStateDescription vmstate_arm_cpu = {
VMSTATE_UINT64(env.exclusive_addr, ARMCPU),
VMSTATE_UINT64(env.exclusive_val, ARMCPU),
VMSTATE_UINT64(env.exclusive_high, ARMCPU),
- VMSTATE_UINT64(env.features, ARMCPU),
+ VMSTATE_UNUSED(sizeof(uint64_t)),
VMSTATE_UINT32(env.exception.syndrome, ARMCPU),
VMSTATE_UINT32(env.exception.fsr, ARMCPU),
VMSTATE_UINT64(env.exception.vaddress, ARMCPU),
--
2.17.1
Re: ARM Snapshots Not Backwards-Compatible, Aaron Lindsay, 2021/02/03
- Re: ARM Snapshots Not Backwards-Compatible, Philippe Mathieu-Daudé, 2021/02/03
- Re: ARM Snapshots Not Backwards-Compatible, Dr. David Alan Gilbert, 2021/02/03
- Re: ARM Snapshots Not Backwards-Compatible, Peter Maydell, 2021/02/03
- Re: ARM Snapshots Not Backwards-Compatible, Aaron Lindsay, 2021/02/03
- [PATCH] target/arm: Don't migrate CPUARMState.features,
Aaron Lindsay <=
- Re: [PATCH] target/arm: Don't migrate CPUARMState.features, Philippe Mathieu-Daudé, 2021/02/03
- Re: [PATCH] target/arm: Don't migrate CPUARMState.features, Andrew Jones, 2021/02/03
- Re: [PATCH] target/arm: Don't migrate CPUARMState.features, Peter Maydell, 2021/02/08
Re: ARM Snapshots Not Backwards-Compatible, Aaron Lindsay, 2021/02/03