Re: [PATCH v5 15/31] exec: Rename guest_{addr, range}_valid to *_untagged

[Peter Maydell]

On Wed, 3 Feb 2021 at 19:00, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> The places that use these are better off using untagged
> addresses, so do not provide a tagged versions.  Rename
> to make it clear about the address type.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  include/exec/cpu_ldst.h |  4 ++--
>  linux-user/qemu.h       |  4 ++--
>  accel/tcg/user-exec.c   |  9 ++++++---
>  linux-user/mmap.c       | 12 ++++++------
>  linux-user/syscall.c    |  2 +-
>  5 files changed, 17 insertions(+), 14 deletions(-)
>

> @@ -211,13 +212,15 @@ static int probe_access_internal(CPUArchState *env, 
> target_ulong addr,
>          g_assert_not_reached();
>      }
>
> -    if (!guest_addr_valid(addr) || page_check_range(addr, 1, flags) < 0) {
> +    addr = cpu_untagged_addr(env_cpu(env), addr_tagged);

This change isn't part of a simple function-rename and should
presumably be in a different patch?

Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM