Re: [PATCH v2 10/21] exec: Move TranslationBlock typedef to qemu/typedefs.h

[Alex Bennée]

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> On 2/10/21 11:10 PM, Alex Bennée wrote:
>> From: Richard Henderson <richard.henderson@linaro.org>
>> 
>> This also means we don't need an extra declaration of
>> the structure in hw/core/cpu.h.
>> 
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>> Message-Id: <20210208233906.479571-2-richard.henderson@linaro.org>
>
> I'd say this one matters ^,
>
>> Message-Id: <20210209182749.31323-2-alex.bennee@linaro.org>
>
> but this one less.

My general approach to Message-Id's is to keep the one from where I
snarfed the patch and the last Message-Id from whichever iteration of
posting it's had. IOW the second one will be replaced by whatever the ID
is of the parent post here.

>
>> ---
>>  include/exec/tb-context.h     | 1 -
>>  include/hw/core/cpu.h         | 4 +---
>>  include/hw/core/tcg-cpu-ops.h | 3 +--
>>  include/qemu/typedefs.h       | 1 +
>>  target/arm/internals.h        | 3 +--
>>  target/cris/translate.c       | 2 +-
>>  target/lm32/translate.c       | 2 +-
>>  target/moxie/translate.c      | 2 +-
>>  target/unicore32/translate.c  | 2 +-
>>  9 files changed, 8 insertions(+), 12 deletions(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


-- 
Alex Bennée