|
From: | Richard Henderson |
Subject: | Re: [RFC PATCH 04/24] accel/tcg: Rename user-mode do_interrupt hack as fake_user_exception |
Date: | Fri, 3 Sep 2021 21:07:37 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
On 9/2/21 5:16 PM, Philippe Mathieu-Daudé wrote:
do_interrupt() is sysemu specific. However due to some X86 specific hack, it is also used in user-mode emulation, which is why it couldn't be restricted to CONFIG_SOFTMMU (see the comment around added in commit 78271684719: "cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass"). Keep the hack but rename the handler as fake_user_exception() and restrict do_interrupt() to sysemu. Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org> --- RFC: Any better name / idea here?
I guess I'm ok with fake_user_interrupt. But I believe that this could all be moved into cpu_loop.c. Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
[Prev in Thread] | Current Thread | [Next in Thread] |