[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type
From: |
Peter Maydell |
Subject: |
Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type |
Date: |
Thu, 16 Sep 2021 15:07:12 +0100 |
On Thu, 16 Sept 2021 at 15:06, Cédric Le Goater <clg@kaod.org> wrote:
> OK. The patch I had prepared was a bit more explicit :
>
> /* On 32-bit hosts, lower RAM to 1G because of 2047 MB limit */
> mc->default_ram_size = (HOST_LONG_BITS == 32 ? 1 : 2) * GiB;
>
> I even have a version with a warn_report() since 32-bit hosts are
> not that common these days.
Using warn_report is likely to get the patch bounced because
it adds a new warning to the 'make check' output on 32-bit hosts,
unless you take special care to suppress it when running in qtest...
-- PMM
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, (continued)
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Peter Maydell, 2021/09/14
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Richard Henderson, 2021/09/14
- Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type), Thomas Huth, 2021/09/15
- Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type), Philippe Mathieu-Daudé, 2021/09/15
- Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type), Daniel P . Berrangé, 2021/09/15
- Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type), Philippe Mathieu-Daudé, 2021/09/15
- Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type), Daniel P . Berrangé, 2021/09/15
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Cédric Le Goater, 2021/09/16
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Philippe Mathieu-Daudé, 2021/09/16
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Cédric Le Goater, 2021/09/16
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type,
Peter Maydell <=
[PULL 03/14] watchdog: aspeed: Sanitize control register values, Cédric Le Goater, 2021/09/13
[PULL 01/14] hw: arm: aspeed: Enable eth0 interface for aspeed-ast2600-evb, Cédric Le Goater, 2021/09/13
[PULL 05/14] hw: aspeed_gpio: Simplify 1.8V defines, Cédric Le Goater, 2021/09/13
[PULL 02/14] hw: arm: aspeed: Enable mac0/1 instead of mac1/2 for g220a, Cédric Le Goater, 2021/09/13
[PULL 11/14] arm/aspeed: Add DPS310 to Witherspoon and Rainier, Cédric Le Goater, 2021/09/13
[PULL 10/14] hw/misc: Add Infineon DPS310 sensor model, Cédric Le Goater, 2021/09/13
[PULL 06/14] hw: aspeed_gpio: Clarify GPIO controller name, Cédric Le Goater, 2021/09/13
[PULL 12/14] hw/arm/aspeed: Initialize AST2600 UART clock selection registers, Cédric Le Goater, 2021/09/13
Re: [PULL 00/14] aspeed queue, Peter Maydell, 2021/09/14