|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path |
Date: | Tue, 22 Feb 2022 13:56:01 +0100 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 |
Hi Markus, On 22/2/22 13:02, Markus Armbruster wrote:
Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and the RTC supports the event). What if there's more than one RTC?
w.r.t. RTC, a machine having multiple RTC devices is silly... Assuming one wants to emulate that; shouldn't all QMP events have a qom-path by default? Or have a generic "event-from-multiple-sources" flag which automatically add this field?
Which one changed? New @qom-path identifies it. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- RFC because it's compile-tested only. Worthwhile? Let me know what you think. qapi/misc.json | 4 +++- hw/ppc/spapr_rtc.c | 4 +++- hw/rtc/mc146818rtc.c | 3 ++- hw/rtc/pl031.c | 3 ++- 4 files changed, 10 insertions(+), 4 deletions(-)
[Prev in Thread] | Current Thread | [Next in Thread] |