[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 13/60] target/arm: Use tcg_constant in translate-a64.c
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 13/60] target/arm: Use tcg_constant in translate-a64.c |
Date: |
Thu, 21 Apr 2022 19:49:12 +0100 |
On Sun, 17 Apr 2022 at 18:59, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Use tcg_constant_{i32,i64,ptr} as appropriate throughout, which
> means we get to remove lots of tcg_temp_free_*. Drop variables
> in many cases, passing the constant directly to another function.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/translate-a64.c | 302 +++++++++++--------------------------
> 1 file changed, 90 insertions(+), 212 deletions(-)
Split this one up a bit, please. It's not too hard to review because
all the changes are local, but if we find there's a regression
in here later I don't really want to have to wade through a 300 line
diff to find it...
thanks
-- PMM
- Re: [PATCH v3 07/60] target/arm: Extend store_cpu_offset to take field size, (continued)
- [PATCH v3 11/60] target/arm: Split out set_btype_raw, Richard Henderson, 2022/04/17
- [PATCH v3 14/60] target/arm: Simplify GEN_SHIFT in translate.c, Richard Henderson, 2022/04/17
- [PATCH v3 10/60] target/arm: Remove fpexc32_access, Richard Henderson, 2022/04/17
- [PATCH v3 12/60] target/arm: Split out gen_rebuild_hflags, Richard Henderson, 2022/04/17
- [PATCH v3 13/60] target/arm: Use tcg_constant in translate-a64.c, Richard Henderson, 2022/04/17
- Re: [PATCH v3 13/60] target/arm: Use tcg_constant in translate-a64.c,
Peter Maydell <=
- [PATCH v3 20/60] target/arm: Use smin/smax for do_sat_addsub_32, Richard Henderson, 2022/04/17
- [PATCH v3 22/60] target/arm: Use tcg_constant in translate-vfp.c, Richard Henderson, 2022/04/17
- [PATCH v3 29/60] target/arm: Change cpreg access permissions to enum, Richard Henderson, 2022/04/17
- [PATCH v3 21/60] target/arm: Use tcg_constant in translate-sve.c, Richard Henderson, 2022/04/17
- [PATCH v3 25/60] target/arm: Reorg CPAccessResult and access_check_cp_reg, Richard Henderson, 2022/04/17