[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/18] RFC: Remove deprecated audio features
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH 00/18] RFC: Remove deprecated audio features |
Date: |
Tue, 26 Apr 2022 09:54:37 +0100 |
On Mon, Apr 25, 2022 at 10:21:43AM +0200, Martin Kletzander wrote:
> I wanted to deal with https://bugzilla.redhat.com/2043498 and I got a
> suggesstion that removing deprecated features could actually make it
> easier to propagate the error. In the end (last patch) it turns out the
> error is still just reported with error_fatal, so it probably is not
> really needed, but I really wanted to dig into QEMU more and learn some
> of the internals for quite some time now. So I used the opportunity.
> The one-liner ended up being an 18 patch series which was, for someone
> who has just one commit in QEMU codebase, a pretty challenging task.
> Although I tried my best to do things properly, I am not sure whether I
> handled everything correctly, hence the RFC.
>
> Any comments are very much appreciated. Thanks and have a nice day ;)
Hi Martin,
The -soundhw removal looks good to me. I'm not familiar with the audio
subsystem so I didn't review the rest.
Stefan
signature.asc
Description: PGP signature
- Re: [PATCH 07/18] Introduce machine's default-audiodev property, (continued)